Regards,
-Gonglei
> -----Original Message-----
> From: linux-crypto-ow...@vger.kernel.org
> [mailto:linux-crypto-ow...@vger.kernel.org] On Behalf Of Sam Ravnborg
> Sent: Saturday, December 10, 2016 5:59 AM
> To: Gonglei (Arei)
> Cc: linux-ker...@vger.kernel.org; qemu-de...@nongnu.org;
> virtio-...@lists.oasis-open.org; virtualizat...@lists.linux-foundation.org;
> linux-crypto@vger.kernel.org; Luonengjun; m...@redhat.com;
> stefa...@redhat.com; Huangweidong (C); Wubin (H); xin.z...@intel.com;
> Claudio Fontana; herb...@gondor.apana.org.au; pa...@linux.vnet.ibm.com;
> da...@davemloft.net; Zhoujian (jay, Euler); Hanweidong (Randy);
> arei.gong...@hotmail.com; cornelia.h...@de.ibm.com; Xuquan (Quan Xu);
> longpeng; Wanzongshun (Vincent); sparcli...@vger.kernel.org
> Subject: Re: [PATCH v6 1/2] sparc: fix a building error reported by kbuild
>
> Hi Gonglei.
>
> On Thu, Dec 08, 2016 at 12:37:08PM +0800, Gonglei wrote:
> > >> arch/sparc/include/asm/topology_64.h:44:44:
> > error: implicit declaration of function 'cpu_data'
> > [-Werror=implicit-function-declaration]
> >
> > #define topology_physical_package_id(cpu) (cpu_data(cpu).proc_id)
> > ^
> > Let's include cpudata.h in topology_64.h.
> >
> > Cc: Sam Ravnborg <s...@ravnborg.org>
> > Cc: David S. Miller <da...@davemloft.net>
> > Cc: sparcli...@vger.kernel.org
> > Suggested-by: Sam Ravnborg <s...@ravnborg.org>
> > Signed-off-by: Gonglei <arei.gong...@huawei.com>
> Acked-by: Sam Ravnborg <s...@ravnborg.org>
>
Thanks.
> > ---
> > arch/sparc/include/asm/topology_64.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/sparc/include/asm/topology_64.h
> b/arch/sparc/include/asm/topology_64.h
> > index 7b4898a..2255430 100644
> > --- a/arch/sparc/include/asm/topology_64.h
> > +++ b/arch/sparc/include/asm/topology_64.h
> > @@ -4,6 +4,7 @@
> > #ifdef CONFIG_NUMA
> >
> > #include <asm/mmzone.h>
> > +#include <asm/cpudata.h>
>
> Nitpick - if you are going to resend this patch,
It depends on the maintainer's thought. :)
> then please order the two includes in alphabetic order.
>
> For two includes this looks like bikeshedding, but when we add
> more having them in a defined arder prevents merge conflicts.
> And makes it readable too.
>
> We also sometimes order the includes with the longest lines topmost,
> and lines with the ame length are ordered alphabetically.
> But this is not seen so often.
>
Regards,
-Gonglei
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
