On Fri, Oct 05, 2018 at 07:16:13PM +0200, Ard Biesheuvel wrote:
> On 5 October 2018 at 19:13, Eric Biggers <ebigg...@kernel.org> wrote:
> > From: Eric Biggers <ebigg...@google.com>
> >
> > aesni-intel_glue.c still calls crypto_fpu_init() and crypto_fpu_exit()
> > to register/unregister the "fpu" template. But these functions don't
> > exist anymore, causing a build error. Remove the calls to them.
> >
> > Fixes: 944585a64f5e ("crypto: x86/aes-ni - remove special handling of AES
> > in PCBC mode")
> > Signed-off-by: Eric Biggers <ebigg...@google.com>
>
> Thanks for spotting that.
>
> I had actually noticed myself, but wasn't really expecting this RFC
> patch to be picked up without discussion.
>
The patch seems reasonable to me -- we shouldn't maintain a special FPU template
just for AES-PCBC when possibly no one is even using that algorithm.
- Eric
