If the parameter type provided to adf_cfg_add_key_value_param()
is invalid, return -EINVAL instead of -1 that is treated as -EPERM and
may confuse.

Suggested-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
Signed-off-by: Giovanni Cabiddu <giovanni.cabi...@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
 drivers/crypto/qat/qat_common/adf_cfg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_common/adf_cfg.c 
b/drivers/crypto/qat/qat_common/adf_cfg.c
index 22ae32838113..f2a29c70d61a 100644
--- a/drivers/crypto/qat/qat_common/adf_cfg.c
+++ b/drivers/crypto/qat/qat_common/adf_cfg.c
@@ -243,7 +243,7 @@ int adf_cfg_add_key_value_param(struct adf_accel_dev 
*accel_dev,
        } else {
                dev_err(&GET_DEV(accel_dev), "Unknown type given.\n");
                kfree(key_val);
-               return -1;
+               return -EINVAL;
        }
        key_val->type = type;
        down_write(&cfg->lock);
-- 
2.26.2

Reply via email to