Using ptep_get() and its counterparts in common code is suboptimal on
kernel configurations with generic compile-time folded page tables.
By default, ptep_get() and its friends expands to READ_ONCE(),
forcing the compiler to emit a load even when the value is not used afterwards.
This issue was recently reported by Christophe Leroy [1] for ppc32
preventing futher code conversion to ptep_get()/pmdp_get()/... helper
and the same behavior can also be observed on arm64 when built with
2- or 3-level page tables
e.g) perf_get_page_size() in arm64 with CONFIG_PGTABLE_LEVEL=3:
00000000000052a0 <perf_get_page_size>:
...
52dc: d53b4234 mrs x20, DAIF
52e0: d50343df msr DAIFSet, #0x3
...
52fc: d35e9a69 ubfx x9, x19, #30, #9 /*
pud_offset_lockless() */
5300: f9403508 ldr x8, [x8, #0x68]
5304: f869790a ldr x10, [x8, x9, lsl #3] /* pudp_get() */
5308: f90007ea str x10, [sp, #0x8]
530c: f8697908 ldr x8, [x8, x9, lsl #3] /* pudp_get() */
...
5360: 90000009 adrp x9, 0x5000 <perf_prepare_sample+0x548>
5364: 92746908 and x8, x8, #0x7ffffff000
5368: d3557675 ubfx x21, x19, #21, #9 /*
pmd_offset_lockless() */
...
5394: f8757ac8 ldr x8, [x22, x21, lsl #3] /* pmdp_get() */
Though PGTABLE_LEVEL=3, since the pudp_get() still remain with
READ_ONCE(), there's redundant load for the pud which is folded.
To prevent generating suboptimal code, define dummy pXdp_get() and
pXd_offset_lockless() in the pgtable-nopXd.h to handle folded page tables
properly.
As the pXdp_get() can return *dummy* entry, some of code using
the stack value where saves the pXdp_get() could be a problematic:
1. Passing address of stack value where saves the pXdp_get() result
to pXd_offset() for example:
pud_t *pudp, pud;
pmd_t *pmdp;
pud = pudp_get(pudp, address);
pmdp = pmd_offset(&pud, pud, address);
(e.g. host_pfn_mapping_level() in loongarch).
2. Using the pXdp_get() result to use as argument of pXd_val() and
to check prot without checking pgtable is folded.
for example, x86's effective_prot().
3. Using set_pXd() with pXdp_get() will set problematic dummy entry
in folded page table like:
set_pXd(pxdp, pXdp_get(pxdp_k));
To prevent this, Let set_pXd() triggers the compile error
to catch the wrong usage of set_pXd() in the generic compile-time
folded page table and change the set_pgd() usage to set the
first-level page table with the proper set_pXd().
4. Using pgd_page_vaddr() to get the first-level pgtable.
passing dummy pxdp_get() for pgd_page_vaddr() will return wrong
address. Therefore, make pgd_page_vaddr() and pXd_pgtable() to
trigger the error for improper usage in the generic compile-time
folded pgtable.
Thanksfully, above cases are rare since (1) most of usage using
pXd_offset() with result of upper pXd_offset(), (2) it's extreamely
rare to use pXd_val() for non-leaf entry in the kernel,
(3) is to handle the vmalloc_fault or set the first level of page table
and (4) to setup early page table and etc.
Therefore, convert this kind of problematic rare pattern properly.
Furthermore, passing the ptep_get() (or its counterparts) as argument
directly to pte_present() and related helpers can generate suboptimal code,
in arm64 as the current macro implementation may evaluate its argument
more than once like:
!pte_val(READ_ONCE(*pte) || pte_present_invalid(READ_ONCE(*pte))
resulting in redundant loads.
A typical example is pud_free_pmd_page(), where the expansion of
pmd_present() generates:
...
/* pmd_present() (x20 = pmdp) */
1b88: f9400288 ldr x8, [x20] // read pmdp.
1b8c: f9000fa8 str x8, [x29, #0x18]
1b90: 3707fec8 tbnz w8, #0x0, 0x1b68 <pud_free_pmd_page+0xd0>
1b94: f9400288 ldr x8, [x20] // redundant read of pmdp.
1b98: 8a170109 and x9, x8, x23
1b9c: f9000fa8 str x8, [x29, #0x18]
1ba0: f120013f cmp x9, #0x800
1ba4: 54fffe20 b.eq 0x1b68 <pud_free_pmd_page+0xd0>
1ba8: 17fffff4 b 0x1b78 <pud_free_pmd_page+0xe0>
...
To address this in arm64, convert pte_present() macro and its friends
to static inline function.
Future work
===========
- print_bad_page_map() and show_pte() still prints dummy values
instead of printing the same content for all generic compile-time
folded page tables. We might want to skip printing dummy values later.
- We currently catch abuse of dummy values on the stack at compile-time by
relying on constant propagation by the compiler. Usama's work [3] on using
distinct types for sw vs. hw PTEs could help here as well."
Link: [1]
https://lore.kernel.org/all/[email protected]/
Link: [2]
https://lore.kernel.org/all/[email protected]/
Link: [3] https://lore.kernel.org/r/[email protected]
David Hildenbrand (Arm) (13):
ARM: mm: make nommu pgd_t a scalar
ARM: mm: make 2-level pgd_t a scalar
ARM: mm: remove custom pgdp_get()
LoongArch: mm: define pud_leaf() only when PUD exists
MIPS: mm: define pud_leaf() only when PUD exists
mm/pgtable: define (pgd|p4d|pud)_leaf() for folded page tables
mm/pgtable: define (pgd|p4d|pud)_offset_lockless() for folded page
tables
x86: mm: carve out the generic compile-time folded pgtable case in
effective_prot()
mm/pgtable: disallow calling folded set_pgd/set_p4d/set_pud
mm/pgtable: disallow calling folded (pgd|p4d|pud)_page,
pgd_page_vaddr() and (p4d|pud)_pgtable
mm/pgtable: optimize pmdp_get() and friends for folded pagetable
levels
openrisc/pgtable: drop __pmd_offset()
mm/pgtable: catch abuse of folded dummy pgd_t/p4d_t/pud_t
Yeoreum Yun (21):
loongarch: kvm: remove stack copy address of pXd in pXd_offset()
riscv: kvm: remove stack copy address of pXd in pXd_offset()
mm: vmscan: remove stack copy address of pud pass in wallk_pud_range()
arm64: mm: use proper set_pXd() for generic compile-time folded
patable in kasan_early_init()
arm64: mm: define pud_set_huge() when __PGTABLE_PMD_FOLDED not defined
csky: mm: use proper set_pXd() for generic compile-time folded patable
in vmalloc_fault()
mips: mm: use proper set_pXd() for generic compile-time folded patable
in vmalloc_fault path
nios2: mm: use proper set_pXd() for generic compile-time folded
patable in vmalloc_fault path
riscv: mm: use proper set_pXd() for generic compile-time folded
patable in vmalloc_fault()
riscv: mm: use proper set_pXd() for generic compile-time folded
patable in setup_vm_final()
x86: power: use proper set_pXd() for generic compile-time folded
patable in resume_one_md_table_init()
x86: kexec: use proper set_pXd() for generic compile-time folded
patable in machine_kexec_page_table_set_one()
x86: platform: use proper set_pXd() for generic compile-time folded
patable in setup_olpc_ofw_pgd()
x86: mm: use proper set_pXd() for generic compile-time folded patable
in one_md_table_init()
x86: mm: skip pud setup when using generic compile-time folded
pagetable
x86: mm: call try_to_free_pmd_page() when CONFIG_PGTABLE_LEVELS > 2
x86: mm: remove usage of pgd_page_vaddr() for CONFIG_x86_PAE
x86: mm: define pudp_set_access_flags() when
CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD is enabled only.
m68k: mm: remove usage of pgd_page_vaddr() for CONFIG_PGTABLE_LEVELS=3
arm: mm: use proper pgtable APIs for generic compile-time folded
patable in kasan_init()
arm64: pgtable: convert pte_present() from macro to static inline
arch/arm/include/asm/page-nommu.h | 4 +-
arch/arm/include/asm/pgtable-2level-types.h | 13 ++++--
arch/arm/include/asm/pgtable.h | 2 -
arch/arm/mm/kasan_init.c | 8 ++--
arch/arm64/include/asm/pgtable.h | 35 ++++----------
arch/arm64/mm/kasan_init.c | 26 ++++++++++-
arch/arm64/mm/mmu.c | 2 +
arch/csky/mm/fault.c | 35 +++++---------
arch/loongarch/include/asm/pgtable.h | 2 +
arch/loongarch/kvm/mmu.c | 20 ++++----
arch/m68k/mm/init.c | 2 +-
arch/m68k/mm/motorola.c | 2 +-
arch/mips/include/asm/pgtable.h | 2 +
arch/mips/mm/fault.c | 13 ++++--
arch/nios2/mm/fault.c | 36 +++++---------
arch/openrisc/include/asm/pgtable.h | 3 --
arch/riscv/kvm/mmu.c | 20 ++++----
arch/riscv/mm/fault.c | 52 +++++++++++++--------
arch/riscv/mm/init.c | 7 ++-
arch/x86/kernel/machine_kexec_32.c | 8 ++--
arch/x86/mm/dump_pagetables.c | 18 ++++++-
arch/x86/mm/init_32.c | 10 ++--
arch/x86/mm/pat/set_memory.c | 9 ++--
arch/x86/mm/pgtable.c | 43 ++++++++++-------
arch/x86/platform/olpc/olpc_ofw.c | 5 +-
arch/x86/power/hibernate_32.c | 14 ++----
include/asm-generic/pgtable-nop4d.h | 45 ++++++++++++++----
include/asm-generic/pgtable-nopmd.h | 46 +++++++++++++-----
include/asm-generic/pgtable-nopud.h | 46 ++++++++++++++----
include/linux/pgtable.h | 5 ++
mm/vmscan.c | 2 +-
31 files changed, 329 insertions(+), 206 deletions(-)
base-commit: bdc38bfc1262e3d1432afadd2aa2ffd83d139dbb
--
LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}
