On Fri, 2019-01-04 at 23:10 +0100, Federico Vaga wrote: > On Friday, January 4, 2019 10:08:33 PM CET Bart Van Assche wrote: > > In emacs 23.1 support for directory-local variables was added (see also > > https://lists.gnu.org/archive/html/info-gnu-emacs/2009-07/msg00000.html). > > Simplify the settings in coding-style.rst by using that feature. > > Additionally, do not inherit any settings from emacs' linux coding style > > to minimize dependencies on the version of emacs that is being used. > > > > I have verified with several large and nontrivial kernel source files > > that the new settings format code according to what checkpatch expects. > > > > Signed-off-by: Bart Van Assche <[email protected]> > > Cc: Matthew Wilcox <[email protected]> > > Cc: Geyslan G. Bem <[email protected]> > > Cc: Tiago Natel de Moura <[email protected]> > > Cc: Alison Chaiken <[email protected]> > > Cc: Joe Perches <[email protected]> > > Cc: Federico Vaga <[email protected]> > > Cc: Li Yang <[email protected]> > > --- > > Documentation/process/coding-style.rst | 57 +++++++++++++++++--------- > > 1 file changed, 37 insertions(+), 20 deletions(-) > > > > Changes compared to v1: > > - Removed top-level .dir-locals.el file again and updated coding-style.rst > > instead. - Restored the humourous paragraph about emacs. > > - Left out Italian and Chinese translations. > > Since now there are only code changes, I think you can apply them on both > Italian and Chinese translations.
Good point. > As a general comment, I personally think that it worth to mention the fact > that the user can take this code (actually part of it) and put it in a .dir- > locals.el file in the top-level directory. I'm not sure we should recommend this. Settings in ~/.emacs are not affected by git clean -f -x but .dir-locals.el is removed by that command. Thanks, Bart.
