On 15/08/2019 22:05, Borislav Petkov wrote: > On Thu, Aug 15, 2019 at 09:59:03PM +0100, Andrew Cooper wrote: >> If you're virtualised, the write to MSR_AMD64_CPUID_FN_1 almost >> certainly won't take effect, which means userspace will still be able to >> see the bit. > msr_clear_bit() has a return value. We should check it before > doing anything further. I hope the HV actually signals the write > success/failure properly so that we get a correct return value.
I'm afraid that a number of hypervisors do write-discard, given the propensity of OSes (certainly traditionally) to go poking at bits like this without wrmsr_safe(). You either need to read the MSR back and observe that the bit has really changed, or in this case as Thomas suggests, look at CPUID again (which will likely be the faster option for the non-virtualised case). ~Andrew
