On Fri, Nov 19, 2021 at 04:12:18PM +0000, Joao Martins wrote:
> > Dan, any thoughts (see also below) ? You probably hold all that
> > history since its inception on commit 2232c6382a4 ("device-dax: Enable
> > page_mapping()")
> > and commit 35de299547d1 ("device-dax: Set page->index").
> >
> Below is what I have staged so far as a percursor patch (see below scissors
> mark).
>
> It also lets me simplify compound page case for __dax_set_mapping() in this
> patch,
> like below diff.
>
> But I still wonder whether this ordering adjustment of @mapping setting is
> best placed
> as a percursor patch whenever pgmap/page refcount changes happen. Anyways
> it's just a
> thought.
naively I would have thought you'd set the mapping on all pages when
you create the address_space and allocate pages into it. AFAIK devmap
assigns all pages to a single address_space, so shouldn't the mapping
just be done once?
Jason
