On Fri, Mar 22, 2024 at 09:49:36PM +1300, Barry Song wrote:

> The driver code, for itself, seems be quite innocent and placing
> maybe_unused seems pointless,
> 
>  struct page *dst_page = sg_page(req->dst);
> 
>  for (i = 0; i < nr_pages; i++)
>       flush_dcache_page(dst_page + i);
> 
> And it should be independent of architectural implementation
> differences.
> 
> Let's provide guidance on coding style for requesting parameter
> evaluation or proposing the migration to a static inline
> function.

Reviewed-by: Mark Brown <[email protected]>

Attachment: signature.asc
Description: PGP signature

Reply via email to