On Mon, 13 May 2024 00:36:58 +0800 Heng Qi wrote: > This failed use case seems to come from this series triggering a problem that > has not been triggered historically, namely lockdep_rtnl_is_held() is not > called > in an environment where CONFIG_NET is not configured and CONFIG_PROVE_LOCKING > is > configured: > If CONFIG_PROVE_LOCKING is configured as Y and CONFIG_NET is n, then > lockdep_rtnl_is_held is in an undefined state at this time. > > So I think we should declare "CONFIG_PROVE_LOCKING depends on CONFIG_NET". > How do you think?
Doesn't sound right, can we instead make building lib/dim/net_dim.c dependent on CONFIG_NET? Untested but I'm thinking something like: diff --git a/lib/dim/Makefile b/lib/dim/Makefile index c4cc4026c451..c02c306e2975 100644 --- a/lib/dim/Makefile +++ b/lib/dim/Makefile @@ -4,4 +4,8 @@ obj-$(CONFIG_DIMLIB) += dimlib.o -dimlib-objs := dim.o net_dim.o rdma_dim.o +dimlib-objs := dim.o rdma_dim.o + +ifeq ($(CONFIG_NET),y) +dimlib-objs += net_dim.o +endif
