Re: [PATCH v2 04/15] iommupt: Add the AMD IOMMU v1 page table format

[ALOK TIWARI]

On 05-05-2025 19:48, Jason Gunthorpe wrote:

+       /*
+        * Table 14: Example Page Size Encodings
+        * Address bits 51:32 can be used to encode page sizes greater that 4
+        * Gbytes. Address bits 63:52 are zero-extended.
+        *

typo, greater that 4 Gbytes -> greater than 4 Gbytes

+        * 512GB Pages are not supported due to a hardware bug.
+        * Otherwise every power of two size is supported.
+        */
+       return GENMASK_ULL(min(51, isz_lg2 + amdv1pt_num_items_lg2(pts) - 1),
+                          isz_lg2) & ~SZ_512G;

Thanks,
Alok