> -----Original Message----- > From: Paolo Abeni <pab...@redhat.com> > Sent: Tuesday, May 20, 2025 3:38 PM > To: Eric Dumazet <eduma...@google.com>; Chia-Yu Chang (Nokia) > <chia-yu.ch...@nokia-bell-labs.com> > Cc: linux-doc@vger.kernel.org; cor...@lwn.net; ho...@kernel.org; > dsah...@kernel.org; kun...@amazon.com; b...@vger.kernel.org; > net...@vger.kernel.org; dave.t...@gmail.com; j...@mojatatu.com; > k...@kernel.org; step...@networkplumber.org; xiyou.wangc...@gmail.com; > j...@resnulli.us; da...@davemloft.net; andrew+net...@lunn.ch; > donald.hun...@gmail.com; a...@fiberby.net; liuhang...@gmail.com; > sh...@kernel.org; linux-kselft...@vger.kernel.org; i...@kernel.org; > ncardw...@google.com; Koen De Schepper (Nokia) > <koen.de_schep...@nokia-bell-labs.com>; g.white <g.wh...@cablelabs.com>; > ingemar.s.johans...@ericsson.com; mirja.kuehlew...@ericsson.com; > chesh...@apple.com; rs.i...@gmx.at; jason_living...@comcast.com; vidhi_goel > <vidhi_g...@apple.com> > Subject: Re: [PATCH v7 net-next 09/15] tcp: accecn: AccECN option > > > CAUTION: This is an external email. Please be very careful when clicking > links or opening attachments. See the URL nok.it/ext for additional > information. > > > > On 5/20/25 12:32 PM, Eric Dumazet wrote: > > On Tue, May 20, 2025 at 2:31 AM Paolo Abeni <pab...@redhat.com> wrote: > >> > >> On 5/14/25 3:56 PM, chia-yu.ch...@nokia-bell-labs.com wrote: > >>> This patch uses the existing 1-byte holes in the tcp_sock_write_txrx > >>> group for new u8 members, but adds a 4-byte hole in > >>> tcp_sock_write_rx group after the new u32 delivered_ecn_bytes[3] > >>> member. Therefore, the group size of tcp_sock_write_rx is increased from > >>> 96 to 112. > >> > >> Note that I'm still concerned by the relevant increase of the > >> cacheline groups size. My fear is that this change could defeat > >> some/most of the benefist from the cacheline reorg for all tcp users. > >> > >> Some additional feedback from Eric and/or Neal more than welcome! > > > > I have been trapped lately with production issues, sorry for the delay. > > > > I am still working on an idpf bug, hopefully done today. > > > > Then, I am OOO tomorrow, and can have a look at the whole series on > > Thursday. > > Thanks Eric! > > @Chia-Yu: please consider the above timeline before posting a new revision. > i.e. it would be likely wise to wait for the additional review. > > /P
Hi Eric and Paolo, As you know that the merge window for v6.16 is begun and net-next is closed for new features till 9th of June. May I ask did you manage yo review the patches we sent two weeks ago? Thanks. Best Regards, Chia-Yu
