On Wed, Jul 09, 2025 at 10:59:14PM -0700, Nicolin Chen wrote:
> Test both IOMMU_HW_INFO_TYPE_DEFAULT and IOMMU_HW_INFO_TYPE_SELFTEST, and
> add a negative test for an unsupported type.
>
> Also drop the unused mask in test_cmd_get_hw_capabilities() as checkpatch
> is complaining.
>
> Signed-off-by: Nicolin Chen <nicol...@nvidia.com>
Reviewed-by: Pranjal Shrivastava <pr...@google.com>
Note: I see a couple of warnings while building the selftests on Jason's
tree, but these seem unrelated to this series:
make -C tools/testing/selftests TARGETS=iommu
make: Entering directory
'/usr/local/google/home/praan/master/iommufd/iommufd/tools/testing/selftests'
CC iommufd
In file included from iommufd.c:12:
In function ‘_test_ioctl_ioas_map_file’,
inlined from ‘iommufd_mock_domain_all_aligns’ at iommufd.c:1789:5,
inlined from ‘wrapper_iommufd_mock_domain_all_aligns’ at iommufd.c:1757:1:
iommufd_utils.h:679:36: warning: ‘mfd’ may be used uninitialized
[-Wmaybe-uninitialized]
679 | struct iommu_ioas_map_file cmd = {
| ^~~
iommufd.c: In function ‘wrapper_iommufd_mock_domain_all_aligns’:
iommufd.c:1766:13: note: ‘mfd’ was declared here
1766 | int mfd;
| ^~~
In function ‘_test_ioctl_ioas_map_file’,
inlined from ‘iommufd_mock_domain_all_aligns_copy’ at iommufd.c:1843:5,
inlined from ‘wrapper_iommufd_mock_domain_all_aligns_copy’ at
iommufd.c:1809:1:
iommufd_utils.h:679:36: warning: ‘mfd’ may be used uninitialized
[-Wmaybe-uninitialized]
679 | struct iommu_ioas_map_file cmd = {
| ^~~
iommufd.c: In function ‘wrapper_iommufd_mock_domain_all_aligns_copy’:
iommufd.c:1818:13: note: ‘mfd’ was declared here
1818 | int mfd;
| ^~~
In file included from iommufd_utils.h:11:
In function ‘_test_cmd_get_hw_info’,
inlined from ‘iommufd_ioas_get_hw_info’ at iommufd.c:792:3,
inlined from ‘wrapper_iommufd_ioas_get_hw_info’ at iommufd.c:752:1:
iommufd_utils.h:812:37: warning: array subscript ‘struct iommu_test_hw_info[0]’
is partly outside array bounds of ‘struct iommu_test_hw_info_buffer_smaller[1]’
[-Warray-bounds=]
812 | assert(!info->flags);
| ~~~~^~~~~~~
iommufd.c: In function ‘wrapper_iommufd_ioas_get_hw_info’:
iommufd.c:761:11: note: object ‘buffer_smaller’ of size 4
761 | } buffer_smaller;
| ^~~~~~~~~~~~~~
CC iommufd_fail_nth
make: Leaving directory
'/usr/local/google/home/praan/master/iommufd/iommufd/tools/testing/selftests'
> ---
> tools/testing/selftests/iommu/iommufd_utils.h | 33 +++++++++++--------
> tools/testing/selftests/iommu/iommufd.c | 32 +++++++++++++-----
> .../selftests/iommu/iommufd_fail_nth.c | 4 +--
> 3 files changed, 46 insertions(+), 23 deletions(-)
>
[...]
> --
> 2.43.0
>
Thanks,
Praan
