Hello, On Thu, 24 Jul 2025 09:20:32 +0200, Hendrik Hamerlinck wrote: > Modified the checkpatch script to ensure that commit tags (e.g., > Signed-off-by, Reviewed-by, Acked-by, Tested-by, etc.) appear in the > correct order according to kernel conventions [1]. > > checkpatch.pl will now emit a BAD_TAG_ORDER warning when tags are out of > the expected sequence. Multiple tags of the same type are allowed, but > they must also follow the order. 'Link:' tags in the changelog are still > allowed before the tag sequence begins, but once the sequence has started, > any 'Link:' tags must follow the ordered commit tags. > > Link: > https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#ordering-of-commit-tags > # [1] >
So, you are citing ordering rules specific to the "tip" tree. I don't think there is any wider consensus with regard to such strict rules. I have to say that your change will make a lot of unneeded noise for most contributors. If such warnings are only shown when the user opted in to the tip rule, say, by using a "--tip" flag or something, they might be helpful. BR, Akira > Signed-off-by: Hendrik Hamerlinck <hendrik.hamerli...@hammernet.be> > --- > Documentation/dev-tools/checkpatch.rst | 6 ++++ > scripts/checkpatch.pl | 40 ++++++++++++++++++++++++++ > 2 files changed, 46 insertions(+) [...]
