> -----Original Message----- > From: Eric Dumazet <eduma...@google.com> > Sent: Thursday, August 21, 2025 2:24 PM > To: Chia-Yu Chang (Nokia) <chia-yu.ch...@nokia-bell-labs.com> > Cc: pab...@redhat.com; linux-doc@vger.kernel.org; cor...@lwn.net; > ho...@kernel.org; dsah...@kernel.org; kun...@amazon.com; > b...@vger.kernel.org; net...@vger.kernel.org; dave.t...@gmail.com; > j...@mojatatu.com; k...@kernel.org; step...@networkplumber.org; > xiyou.wangc...@gmail.com; j...@resnulli.us; da...@davemloft.net; > andrew+net...@lunn.ch; donald.hun...@gmail.com; a...@fiberby.net; > liuhang...@gmail.com; sh...@kernel.org; linux-kselft...@vger.kernel.org; > i...@kernel.org; ncardw...@google.com; Koen De Schepper (Nokia) > <koen.de_schep...@nokia-bell-labs.com>; g.wh...@cablelabs.com; > ingemar.s.johans...@ericsson.com; mirja.kuehlew...@ericsson.com; > chesh...@apple.com; rs.i...@gmx.at; jason_living...@comcast.com; > vidhi_g...@apple.com > Subject: Re: [PATCH v15 net-next 08/14] tcp: accecn: AccECN needs to know > delivered bytes > > > CAUTION: This is an external email. Please be very careful when clicking > links or opening attachments. See the URL nok.it/ext for additional > information. > > > > On Fri, Aug 15, 2025 at 1:39 AM <chia-yu.ch...@nokia-bell-labs.com> wrote: > > > > From: Ilpo Järvinen <i...@kernel.org> > > > > AccECN byte counter estimation requires delivered bytes which can be > > calculated while processing SACK blocks and cumulative ACK. The > > delivered bytes will be used to estimate the byte counters between > > AccECN option (on ACKs w/o the option). > > > > Non-SACK calculation is quite annoying, inaccurate, and likely bogus. > > Does it mean AccECN depends on SACK ? >
In fact, AccECN does not depend on SACK to function; however, it would be more accurate if SACK were there. In order to avoid confusion, I will remove this old comment in the next version. Chia-Yu
