Re: [PATCH v4 03/15] iommupt: Add the basic structure of the iommu implementation

[Randy Dunlap]

On 8/29/25 12:05 PM, Jason Gunthorpe wrote:
>>> +   /*
>>> +    * The aperture is limited to what the API can do after considering all
>>> +    * the different types dma_addr_t/unsigned long/pt_vaddr_t that are used
>>> +    * to store a VA. Set the aperture to something that is valid for all
>>> +    * cases. Saturate instead of truncate the end if the types are smaller
>>> +    * than the top range. aperture_end is a last.
>> Does "is a last" have something to do with terminating loop iteration?
>> Is it inclusive or exclusive?
> It is intended to refer back to the definitions:
> 
>  *  start/end
>  *     An half-open range, e.g. [0,0) refers to no VA.
>  *  start/last
>  *     An inclusive closed range, e.g. [0,0] refers to the VA 0
> 

I see.

> Where aperture_start/aperture_end doesn't follow that standard.

oops

> 
>        * cases. Saturate instead of truncate the end if the types are smaller
>        * than the top range. aperture_end should be called aperture_last.
>        */
> 
> Maybe?

Yes, that's helpful.Thanks.
-- 
~Randy