On Tue, Sep 09, 2025 at 08:01:33PM +0530, Anwar, Md Danish wrote:
> On 9/9/2025 5:39 PM, Dong Yibo wrote:
> > Complete the network device (netdev) registration flow for Mucse Gbe
> > Ethernet chips, including:
> > 1. Hardware state initialization:
> > - Send powerup notification to firmware (via echo_fw_status)
> > - Sync with firmware
> > - Reset hardware
> > 2. MAC address handling:
> > - Retrieve permanent MAC from firmware (via mucse_mbx_get_macaddr)
> > - Fallback to random valid MAC (eth_random_addr) if not valid mac
> > from Fw
> >
> > Signed-off-by: Dong Yibo <dong...@mucse.com>
> > ---
>
> > +/**
> > + * rnpgbe_xmit_frame - Send a skb to driver
> > + * @skb: skb structure to be sent
> > + * @netdev: network interface device structure
> > + *
> > + * Return: NETDEV_TX_OK or NETDEV_TX_BUSY
> > + **/
> > +static netdev_tx_t rnpgbe_xmit_frame(struct sk_buff *skb,
> > + struct net_device *netdev)
> > +{
> > + dev_kfree_skb_any(skb);
> > + netdev->stats.tx_dropped++;
> > + return NETDEV_TX_OK;
> > +}
>
> The function comment says it returns NETDEV_TX_OK or NETDEV_TX_BUSY, but
> it only returns NETDEV_TX_OK.
>
>
Got it, I will fix it, and also check other functions.
> --
> Thanks and Regards,
> Md Danish Anwar
>
>
Thanks for your feedback.
