Hi Donald,
On 09/09/2025 10:44, Donald Hunter wrote:
> "Matthieu Baerts (NGI0)" <matt...@kernel.org> writes:
>
>> This attribute is used as a signed number in the code in pm_netlink.c:
>>
>> nla_put_s32(skb, MPTCP_ATTR_IF_IDX, ssk->sk_bound_dev_if))
>>
>> The specs should then reflect that. Note that other 'if-idx' attributes
>> from the same .yaml file use a signed number as well.
>
> Note that mptcp_pm_parse_entry has this, which should maybe be fixed at
> the same time:
>
> u32 val = nla_get_s32(tb[MPTCP_PM_ADDR_ATTR_IF_IDX]);
Good catch!
This should be fixed in a dedicated patch, because this fixes commit:
ef0da3b8a2f1 ("mptcp: move address attribute into mptcp_addr_info"), a
different commit than the one being fixed here.
I can send that separately later on if that's OK.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
