> From: Jason Gunthorpe <j...@nvidia.com> > Sent: Wednesday, September 24, 2025 8:24 PM > > On Wed, Sep 24, 2025 at 09:28:12AM +0000, Tian, Kevin wrote: > > > + if (pts.type == PT_ENTRY_OA) { > > > + if (log2_mod(range->va, pt_entry_oa_lg2sz(&pts))) > > > + return -EINVAL; > > > + goto start_oa; > > > + } > > > > it's not typical goto a location inside a loop. > > > > Actually even w/o that goto, the flow will continue to... > > Yes, but this is a micro optimization, can actually measure it in the > benchmarks :\ >
a comment is preferred in this case. 😊