On 10/31/25 1:07 PM, Paul Walmsley wrote: > On Thu, 23 Oct 2025, Deepak Gupta via B4 Relay wrote: > >> From: Deepak Gupta <[email protected]> >> >> Save shadow stack pointer in sigcontext structure while delivering signal. >> Restore shadow stack pointer from sigcontext on sigreturn. >> > > This patch causes some 'checkpatch.pl --strict' messages: > > CHECK: Comparison to NULL could be written "!saved_shstk_ptr" > #271: FILE: arch/riscv/kernel/usercfi.c:186: > + if (saved_shstk_ptr == NULL) > > CHECK: Lines should not end with a '(' > #300: FILE: arch/riscv/kernel/usercfi.c:215: > + pr_info_ratelimited( > > I've fixed them up here in the event that v22 goes in, but please do the > same on your side in case a new version is needed. Hi Paul, Is checkpatch.pl --strict the norm for arch/riscv/ ? If there are enough arch/riscv/-specific patch expectations, maybe they could be documented in Documentation/process/maintainer-riscv.rst (a new file). Thanks. -- ~Randy
- [PATCH v22 12/28] riscv: Implements arch agnosti... Deepak Gupta via B4 Relay
- [PATCH v22 10/28] riscv/mm: Implement map_shadow... Deepak Gupta via B4 Relay
- Re: [PATCH v22 10/28] riscv/mm: Implement m... Paul Walmsley
- Re: [PATCH v22 10/28] riscv/mm: Impleme... Maciej W. Rozycki
- [PATCH v22 23/28] arch/riscv: compile vdso with ... Deepak Gupta via B4 Relay
- [PATCH v22 13/28] prctl: arch-agnostic prctl for... Deepak Gupta via B4 Relay
- [PATCH v22 14/28] riscv: Implements arch agnosti... Deepak Gupta via B4 Relay
- [PATCH v22 15/28] riscv/traps: Introduce softwar... Deepak Gupta via B4 Relay
- [PATCH v22 17/28] riscv/signal: save and restore... Deepak Gupta via B4 Relay
- Re: [PATCH v22 17/28] riscv/signal: save an... Paul Walmsley
- Re: [PATCH v22 17/28] riscv/signal: sav... Randy Dunlap
- Re: [PATCH v22 17/28] riscv/signal:... Paul Walmsley
- [PATCH v22 19/28] riscv/ptrace: riscv cfi status... Deepak Gupta via B4 Relay
- [PATCH v22 16/28] riscv: signal: abstract header... Deepak Gupta via B4 Relay
- [PATCH v22 18/28] riscv/kernel: update __show_re... Deepak Gupta via B4 Relay
- [PATCH v22 27/28] riscv: Documentation for shado... Deepak Gupta via B4 Relay
- [PATCH v22 28/28] kselftest/riscv: kselftest for... Deepak Gupta via B4 Relay
- [PATCH v22 21/28] riscv: kernel command line opt... Deepak Gupta via B4 Relay
- [PATCH v22 22/28] riscv: enable kernel access to... Deepak Gupta via B4 Relay
- [PATCH v22 20/28] riscv/hwprobe: zicfilp / zicfi... Deepak Gupta via B4 Relay
- [PATCH v22 25/28] riscv: create a config for sha... Deepak Gupta via B4 Relay
