On 25/11/2025 17:11, ally heev wrote: > On Tue, 2025-11-25 at 16:09 +0100, Krzysztof Kozlowski wrote: >> On 25/11/2025 14:32, Ally Heev wrote: >>> uninitialized pointers with __free attribute can cause undefined >>> behavior as the memory randomly assigned to the pointer is freed >>> automatically when the pointer goes out of scope. >>> add check in checkpatch to detect such issues. >>> >>> Suggested-by: Dan Carpenter <[email protected]> >>> Link: >>> https://lore.kernel.org/all/[email protected]/ >>> Link: >>> https://lore.kernel.org/all/58fd478f408a34b578ee8d949c5c4b4da4d4f41d.ca...@hansenpartnership.com/ >>> Acked-by: Dan Williams <[email protected]> >>> Signed-off-by: Ally Heev <[email protected]> >> >> >> <form letter> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions >> of patchset, under or above your Signed-off-by tag, unless patch changed >> significantly (e.g. new properties added to the DT bindings). Tag is >> "received", when provided in a message replied to you on the mailing >> list. Tools like b4 can help here. However, there's no need to repost >> patches *only* to add the tags. The upstream maintainer will do that for >> tags received on the version they apply. >> >> Please read: >> https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. >> </form letter> >> >> >> Best regards, >> Krzysztof > > Oopsie. I should have sent a new version instead of resending a failed > one. I have updated the `UNINITIALIZED_PTR_WITH_FREE` error description > in the checkpatch doc as outlined in v6 changelog, so, didn't add a > Reviewed-by tag
Again, your changelog should explain the reason. Second, you implemented reviewer suggestion, received the tag so why do you think that Rb tag does not apply? Best regards, Krzysztof
