> -----Original Message----- > From: Neal Cardwell <[email protected]> > Sent: Wednesday, December 3, 2025 5:59 PM > To: Jakub Kicinski <[email protected]> > Cc: Chia-Yu Chang (Nokia) <[email protected]>; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; > [email protected]; [email protected]; Koen De Schepper (Nokia) > <[email protected]>; [email protected]; > [email protected]; [email protected]; cheshire > <[email protected]>; [email protected]; [email protected]; Vidhi Goel > <[email protected]> > Subject: Re: [PATCH v7 net-next 00/13] AccECN protocol case handling series > > > CAUTION: This is an external email. Please be very careful when clicking > links or opening attachments. See the URL nok.it/ext for additional > information. > > > > On Mon, Dec 1, 2025 at 6:05 PM Jakub Kicinski <[email protected]> wrote: > > > > On Mon, 1 Dec 2025 17:37:47 +0100 [email protected] > > wrote: > > > Plesae find the v7 AccECN case handling patch series, which covers > > > several excpetional case handling of Accurate ECN spec (RFC9768), > > > adds new identifiers to be used by CC modules, adds ecn_delta into > > > rate_sample, and keeps the ACE counter for computation, etc. > > > > > > This patch series is part of the full AccECN patch series, which is > > > available at > > > https://gi/ > > > thub.com%2FL4STeam%2Flinux-net-next%2Fcommits%2Fupstream_l4steam%2F& > > > data=05%7C02%7Cchia-yu.chang%40nokia-bell-labs.com%7C31949326090d451 > > > 8264708de328d3cef%7C5d4717519675428d917b70f44f9630b0%7C0%7C0%7C63900 > > > 3779346421209%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOi > > > IwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7 > > > C%7C%7C&sdata=J%2FR5DZJ1XFpY9rRlZOygChTspEEm68zYnaA1ZVYHhrc%3D&reser > > > ved=0 > > Hi Chia-Yu, > > My understanding is that you still have a set of packetdrill tests you have > been using to test this AccECN patch series. For the Linux networking stack, > the recent best practice for a significant patch series like this is to add > packetdrill tests to the tools/testing/selftests/net/packetdrill/ directory > as a separate commit in the patch series. > > For a recent example, see: > > selftest: packetdrill: Add max RTO test for SYN+ACK. > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=ffc56c90819e86d3a8c4eff6f831317d1c1476b6 > > When you next post the AccECN patch series for review, can you please include > a patch at the end of the series that posts your packetdrill tests in the > tools/testing/selftests/net/packetdrill/ directory? In the commit description > for that patch, please include a mention of the packetdrill SHA1 you are > using and a link to the packetdrill branch you are using, somewhere on github > or similar. Then I will look into merging any packetdrill tool changes that > you are depending on, if there are packetdrill commits that you depend on > that I have not merged into packetdrill yet. > > Thanks! > neal
Hi Neal, Sure, I will include packetdrill in a separated patch. But do you know when net-next will be open for submission? Thanks. Chia-Yu
