Hi Steven, The main difference between this patch and Roberto's version is the length of time needed for locking the measurement list, which prevents new entries from being appended to the measurement list. In Roberto's version, the list head is moved quickly and the lock released. Measuring the total amount of time needed to trim the measurement list ignores the benefit of his version. I plan on reviewing both this version and his (hopefully today).
There are a number of other things missing from this patch, which I'll enumerate when I review it. On Wed, 2025-12-10 at 15:53 -0800, steven chen wrote: > This patch is for trimming N entries of the IMA event logs. It will also > cleaning the hash table if ima_flush_htable is set. Please refer to "Describe your changes in imperative mood" in the "Describe your changes" section of Documentation/process/submitting-patches.rst. > > It provides a userspace interface ima_trim_log that can be used to input > number N to let kernel to trim N entries of IMA event logs. When read > this interface, it returns number of entries trimmed last time. > > Signed-off-by: steven chen <[email protected]> -- thanks, Mimi
