Hi Cryolitia,
> From: Cryolitia PukNgae <[email protected]>
> > The tag should be followed by a Closes: tag pointing to the report,
> > unless the report is not available on the web. The Link: tag can be
> > used instead of Closes: if the patch fixes a part of the issue(s)
> > being reported.
Indeed, this is true, although there is a prerequisite:
The Link: tag can be used instead of Closes: if the patch fixes a part
of
the issue(s) being reported.
Reviewed-by: Petr Vorel <[email protected]>
I also see you Cc LTP ML. FYI we vendored scripts/checkpatch.pl (with occasional
updates).
Kind regards,
Petr
> Accroding to Documentation/process/submitting-patches.rst , Link: is
> also acceptable to followed a Reported-by:
> Signed-off-by: Cryolitia PukNgae <[email protected]>
> ---
> Link to previous:
> https://lore.kernel.org/r/[email protected]
> ---
> scripts/checkpatch.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index c0250244cf7a..dac9d98133c6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3209,10 +3209,10 @@ sub process {
> if ($sign_off =~ /^reported(?:|-and-tested)-by:$/i) {
> if (!defined $lines[$linenr]) {
> WARN("BAD_REPORTED_BY_LINK",
> - "Reported-by: should be
> immediately followed by Closes: with a URL to the report\n" . $herecurr .
> "\n");
> - } elsif ($rawlines[$linenr] !~ /^closes:\s*/i) {
> + "Reported-by: should be
> immediately followed by Closes: or Link: with a URL to the report\n" .
> $herecurr . "\n");
> + } elsif ($rawlines[$linenr] !~
> /^(closes|link):\s*/i) {
> WARN("BAD_REPORTED_BY_LINK",
> - "Reported-by: should be
> immediately followed by Closes: with a URL to the report\n" . $herecurr .
> $rawlines[$linenr] . "\n");
> + "Reported-by: should be
> immediately followed by Closes: or Link: with a URL to the report\n" .
> $herecurr . $rawlines[$linenr] . "\n");
> }
> }
> }
