On Tue, Jan 20, 2026 at 4:11 AM Tzung-Bi Shih <[email protected]> wrote: > > On Fri, Jan 16, 2026 at 01:26:01PM +0000, Bartosz Golaszewski wrote: > > On Fri, 16 Jan 2026 09:10:17 +0100, Tzung-Bi Shih <[email protected]> said: > > > On error handling paths, lineinfo_changed_notify() doesn't free the > > > allocated resources which results leaks. Fix it. > > > > > > Cc: [email protected] > > > Fixes: d4cd0902c156 ("gpio: cdev: make sure the cdev fd is still active > > > before emitting events") > > > Signed-off-by: Tzung-Bi Shih <[email protected]> > > > --- > > > drivers/gpio/gpiolib-cdev.c | 5 ++++- > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c > > > index ba1eae15852d..6196aab5ed74 100644 > > > --- a/drivers/gpio/gpiolib-cdev.c > > > +++ b/drivers/gpio/gpiolib-cdev.c > > > @@ -2549,7 +2549,7 @@ static int lineinfo_changed_notify(struct > > > notifier_block *nb, > > > ctx = kzalloc(sizeof(*ctx), GFP_ATOMIC); > > > if (!ctx) { > > > pr_err("Failed to allocate memory for line info > > > notification\n"); > > > - return NOTIFY_DONE; > > > + goto err_put_fp; > > > } > > > > > > ctx->chg.event_type = action; > > > @@ -2563,6 +2563,9 @@ static int lineinfo_changed_notify(struct > > > notifier_block *nb, > > > queue_work(ctx->gdev->line_state_wq, &ctx->work); > > > > > > return NOTIFY_OK; > > > +err_put_fp: > > > + fput(fp); > > > + return NOTIFY_DONE; > > > } > > > > > > static int gpio_device_unregistered_notify(struct notifier_block *nb, > > > -- > > > 2.52.0.457.g6b5491de43-goog > > > > > > > > > > There's only one place where you need this fput(), please do it directly in > > the error path of kzalloc() and drop the label. > > Sure, just wanted to give a heads up: 17/23 might introduce the label back. > > v2: https://lore.kernel.org/all/[email protected]
That's alright, we prefer a smaller patch for backporting. Bart
