On Tue, Jan 20, 2026 at 7:11 PM Chia-Yu Chang (Nokia) <[email protected]> wrote: > > > Hi Eric, > > Thanks for the feedback. > Do you mean sk_listener here is read-only despite there is no const here?
It is not const because we probably need to increment reference counts on it. But if you have 1000 SYN_RECV, they might share the same listener socket, and we do not lock the listener socket, this would not scale very well on servers with 10,000,000 tcp sockets :) So using any listener-fields to store 'per-syn-recv' information is racy. > > Then, could you help to suggest the way please? > Beacuse for AccECN, here we need to set fail flag after retransmitting > SYN/ACK > 1 time. Why not use state in req itself ? (Or tcp_rsk()) > And this was done within tcp_make_synack(), but now move to every place where > could retransmit SYN/ACK. > > Thanks. > Chia-Yu
