> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf > Of Mauro Carvalho Chehab > Sent: Thursday, January 29, 2026 9:08 AM > To: Jonathan Corbet <[email protected]>; Linux Doc Mailing List <linux- > [email protected]> > Cc: Mauro Carvalho Chehab <[email protected]>; > [email protected]; [email protected]; linux- > [email protected]; [email protected]; > [email protected]; Mauro Carvalho Chehab <[email protected]>; > Randy Dunlap <[email protected]> > Subject: [Intel-wired-lan] [PATCH v3 08/30] docs: kdoc_parser: fix the > default_value logic for variables > > The indentation is wrong for the second regex, which causes problems > on variables with defaults. > > Signed-off-by: Mauro Carvalho Chehab <[email protected]> > Acked-by: Randy Dunlap <[email protected]> > Tested-by: Randy Dunlap <[email protected]> > --- > tools/lib/python/kdoc/kdoc_parser.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/lib/python/kdoc/kdoc_parser.py > b/tools/lib/python/kdoc/kdoc_parser.py > index 201c4f7298d7..cbfdaba39494 100644 > --- a/tools/lib/python/kdoc/kdoc_parser.py > +++ b/tools/lib/python/kdoc/kdoc_parser.py > @@ -1035,9 +1035,9 @@ class KernelDoc: > default_val = r.group(2) > else: > r= KernRe(OPTIONAL_VAR_ATTR + > r"(?:[\w_]*)?\s+(?:\*+)?(?:[\w_]+)\s*[\d\]\[]*\s*(=.*)?") > - if r.match(proto): > - default_val = r.group(1) > > + if r.match(proto): > + default_val = r.group(1) > if not declaration_name: > self.emit_msg(ln,f"{proto}: can't parse variable") > return > -- > 2.52.0
Reviewed-by: Aleksandr Loktionov <[email protected]>
