On 1/31/26 11:25 PM, [email protected] wrote:
> From: Chia-Yu Chang <[email protected]>
> 
> Hello,
> 
> Plesae find the v13 AccECN case handling patch series, which covers
> several excpetional case handling of Accurate ECN spec (RFC9768),
> adds new identifiers to be used by CC modules, adds ecn_delta into
> rate_sample, and keeps the ACE counter for computation, etc.
> 
> This patch series is part of the full AccECN patch series, which is at
> https://github.com/L4STeam/linux-net-next/commits/upstream_l4steam/

Beside the just shared feedback, the AI reported a bunch of other stuff
that are not relevant:
- fixes tags, IMHO not needed since the touched features were just
partially implemented before
- uapi breakage, already ruled out as irrelevant since the iproute bits
are not there yet
- pktdrill syntax, which is a little inconsistent but AFAICS correct.

I'm not sure about the BIT() macro usage in uAPI, which is already a
thing in many uAPI exposed headers, but does not look correct. I guess
it could be handled with a follow-up, if needed.

So the only feedback the could really require a new revision is WRT ECN
flags handling on retransmission - and I'm not 110% it needs a new
revision: please double check it.

Thanks,

Paolo


Reply via email to