I've been looking at the sa7146 page table code and it looks like the
saa7146_pgtable_free function is used incorrectly in the error cases:
from budget-core.c:
ttpci_budget_init()
{
...
budget->grabbing = saa7146_vmalloc_build_pgtable(dev->pci,
budget->buffer_size, &budget->pt))
...
err:
i2c_del_adapter(&budget->i2c_adap);
vfree(budget->grabbing);
}
vs:
ttpci_budget_deinit()
{
...
saa7146_pgtable_free(dev->pci, &budget->pt);
Shouldn't the vfree() above be a call to saa7146_pgtable_free() ?
Also in av7110.c:
av7110_attach()
{
...
av7110->grabbing = saa7146_vmalloc_build_pgtable(pdev, length, &av7110->pt);
...
err_saa71466_vfree_4:
if (!av7110->grabbing)
saa7146_pgtable_free(pdev, &av7110->pt);
...
Surely the (!av7110->grabbing) should be (av7110->grabbing) ?
Jon
_______________________________________________
linux-dvb mailing list
[email protected]
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
