[linux-dvb] Re: [PATCH] Skystar2 stylistic micropatch

[Holger Waechtler]

Roberto Ragusa wrote:
Hi,

just a little patch for some stylistical details in skystar2.c.

I think the code has too much empty lines and has poor choice between
int or u32 types ("int i", "u32 i").
I also dislike uppercase hexadecimal.
Should I go on with cosmetics?
Yes, definitely. But your patch did not applied, can you please generate 
your patchsets using 'cvs -q diff -pu' in the future and send them as 
non-inlined attachments?

thanks,

Holger



--- /home/rora/linuxtv/dvb-kernel/linux/drivers/media/dvb/b2c2/skystar2.c       
2003-11-26 15:01:03.000000000 +0100
+++ skystar2.c_01STYLE  2003-11-26 15:38:54.000000000 +0100
@@ -52,7 +52,6 @@
 #define SIZE_OF_BUF_DMA2       0x758
 struct dmaq {
-
        u32 bus_addr;
        u32 head;
        u32 tail;
@@ -62,7 +61,6 @@
 struct adapter {
-
        struct pci_dev *pdev;
        u8 card_revision;
@@ -2265,8 +2263,7 @@
                u8 count;
                fe_sec_mini_cmd_t b = (fe_sec_mini_cmd_t) arg;
                dprintk("%s: FE_SEND_BURST ", __FUNCTION__);
-               switch ( b )
-               {
+               switch ( b ) {
                    case SEC_MINI_A:
                    {
                        dprintk("SEC_MINI_A\n");
@@ -2281,8 +2278,7 @@
                        dprintk("SEC_MINI_B\n");
                        set_tuner_tone(adapter, 0);
                        udelay(1000*15);
-                        for (count=0;count<9; count++)
-                       {
+                        for (count=0;count<9; count++) {
                                set_tuner_tone(adapter, 1);
                                udelay(500);
                                set_tuner_tone(adapter, 0);
@@ -2312,8 +2308,7 @@
            {
                dprintk("%s: FE_SET_VOLTAGE\n", __FUNCTION__);
-               switch ((fe_sec_voltage_t) arg)
-               {
+               switch ((fe_sec_voltage_t) arg) {
                        case SEC_VOLTAGE_13:
                                dprintk("%s: SEC_VOLTAGE_13, %x\n", __FUNCTION__, 
SEC_VOLTAGE_13);
@@ -2343,12 +2338,10 @@
                fe->ioctl(fe, FE_GET_INFO, &info);

-               if ( strcmp(info.name, "Zarlink MT312") == 0)
-               {
+               if ( strcmp(info.name, "Zarlink MT312") == 0) {
                    dprintk("%s: FE_SET_TONE for %s frontend\n", __FUNCTION__, 
info.name);
-                   switch ((fe_sec_tone_mode_t) arg)
-                   {
+                   switch ((fe_sec_tone_mode_t) arg) {
                        case SEC_TONE_ON:
                            dprintk("%s: SEC_TONE_ON, %x\n", __FUNCTION__, 
SEC_TONE_ON);
@@ -2372,8 +2365,7 @@
                };

-               if ( strcmp(info.name, "STV0299/TSA5059/SL1935 based") == 0)
-               {
+               if ( strcmp(info.name, "STV0299/TSA5059/SL1935 based") == 0) {
                    dprintk("%s: FE_SET_TONE for %s frontend\n", __FUNCTION__, 
info.name);
                    /* allow the frontend driver to handle this command*/





--
Info:
To unsubscribe send a mail to [EMAIL PROTECTED] with "unsubscribe linux-dvb" as 
subject.