On Thursday 29 July 2004 23:18, Andreas Share wrote: > there is some thing missing in the patch ...in sp5659_set_tv_freq() is a > "u8 pwr = 0;" needed.
2.6.7 with hand applied "ves1x93_cpc.V2.diff" does not compile ... you remove the last parameter from "sp5659_set_tv_freq" and in function "tuner_set_tv_freq" you call it with one parameter less .... but in function ves1x93_ioctl (and in ves1x93_afc) you call tuner_set_tv_freq also with one parameter left away ... this could not be compiled .. also not for you ;-) even with this fixed, there are warnings left ;-) CC [M] drivers/media/dvb/frontends/ves1x93.o drivers/media/dvb/frontends/ves1x93.c: In function `sp5659_set_tv_freq': drivers/media/dvb/frontends/ves1x93.c:184: warning: ISO C90 forbids mixed declarations and code drivers/media/dvb/frontends/ves1x93.c:186: warning: passing arg 1 of `tuner_write' from incompatible pointer type drivers/media/dvb/frontends/ves1x93.c: In function `tuner_set_tv_freq': drivers/media/dvb/frontends/ves1x93.c:210: warning: passing arg 1 of `sp5659_set_tv_freq' from incompatible pointer type the module is working, and it appears that it reduces my problems a little bit (maybe only statistical noise ;-) i will watch this ... hermann
