Linus Torvalds wrote: > > On Mon, 13 Nov 2006, Michael Krufky wrote: >> Mauro -- that patch needs fixing / more testing before it goes to >> mainstream... >> >> Could you please remove that changeset from your git tree before Linus pulls >> it? > > Too late. Already pulled and pushed out. > > Looking at the patch, one obvious bug stands out: the new case statement > for SAA7134_BOARD_AVERMEDIA_777 doesn't have a "break" at the end. > > José, can you test this trivial patch and see if it fixes things? > > Linus > > --- > diff --git a/drivers/media/video/saa7134/saa7134-input.c > b/drivers/media/video/saa7134/saa7134-input.c > index 7f62403..dee8355 100644 > --- a/drivers/media/video/saa7134/saa7134-input.c > +++ b/drivers/media/video/saa7134/saa7134-input.c > @@ -202,6 +202,7 @@ int saa7134_input_init1(struct saa7134_d > /* Without this we won't receive key up events */ > saa_setb(SAA7134_GPIO_GPMODE1, 0x1); > saa_setb(SAA7134_GPIO_GPSTATUS1, 0x1); > + break; > case SAA7134_BOARD_KWORLD_TERMINATOR: > ir_codes = ir_codes_pixelview; > mask_keycode = 0x00001f;
Thanks for the fix, Linus... I see that you've already pushed this into git, so I've added it to my v4l-dvb hg development tree. Jose, you can use this tree for testing, if you don't want to apply the patch by hand. Mauro, please pull from: http://linuxtv.org/hg/~mkrufky/v4l-dvb for the following: - saa7134: Fix missing 'break' for avermedia card case saa7134-input.c | 1 + 1 file changed, 1 insertion(+) Cheers, Michael Krufky _______________________________________________ linux-dvb mailing list [email protected] http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
