Hi Simon,
Simon Arlott wrote:
> @@ -673,13 +672,8 @@ static int dvb_demux_open(struct inode *
> static int dvb_dmxdev_filter_free(struct dmxdev *dmxdev,
> struct dmxdev_filter *dmxdevfilter)
> {
> - if (mutex_lock_interruptible(&dmxdev->mutex))
> - return -ERESTARTSYS;
> -
> - if (mutex_lock_interruptible(&dmxdevfilter->mutex)) {
> - mutex_unlock(&dmxdev->mutex);
> - return -ERESTARTSYS;
> - }
> + mutex_lock(&dmxdev->mutex);
> + mutex_lock_interruptible(&dmxdevfilter->mutex);Assuming that the rest of the patch is OK, shouldn't this be a mutex_lock(), too, if the return value will be ignored? Regards, Andreas
signature.asc
Description: OpenPGP digital signature
_______________________________________________ linux-dvb mailing list [email protected] http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
