Marco Gittler wrote: > this patch has applied the hints from mkrufky (dvb_attach, > firmware-naming) > and also one working rewrite of the i2c addresses stuff to fit the > kernel i2c reqs. > > Signed-off-by: Marco Gittler<[EMAIL PROTECTED]> > diff -r c8b73ec18b42 linux/drivers/media/dvb/dvb-usb/opera1.c > --- a/linux/drivers/media/dvb/dvb-usb/opera1.c Thu Apr 19 12:04:50 > 2007 -0300 > +++ b/linux/drivers/media/dvb/dvb-usb/opera1.c Thu Apr 19 20:38:01 > 2007 +0200 > @@ -25,6 +25,13 @@ > #define REG_20_SYMBOLRATE_BYTE1 0x20 > #define REG_21_SYMBOLRATE_BYTE2 0x21 > > +#define ADDR_C0_TUNER (0xc0>>1) > +#define ADDR_D0_PLL (0xd0>>1) > I don't like these two #define's. These i2c addresses need only be specified once, in the config structs / frontendfoo_attach calls for the tuner / demod.
Better to just put them in as constants like all of the other dvb drivers. Regards, Mike Krufky _______________________________________________ linux-dvb mailing list [email protected] http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
