On Mon, 2007-05-07 at 06:20 +1000, System Administrator wrote: > I think that the bug is that xc3028_attach is returning 0 to indicate > success whereas dvb_attach() is treating 0 as failure?
Hello again, I have verified that this is indeed what is happening. xc3028_tuner should be returning a pointer on success, not 0. Here's a patch to fix that. Daniel
diff -ruN v4l-dvb-experimental.orig/linux/drivers/media/tuners/xc3028-tuner.c v4l-dvb-experimental/linux/drivers/media/tuners/xc3028-tuner.c --- v4l-dvb-experimental.orig/linux/drivers/media/tuners/xc3028-tuner.c 2007-05-06 18:36:26.000000000 +1000 +++ v4l-dvb-experimental/linux/drivers/media/tuners/xc3028-tuner.c 2007-05-07 06:42:14.596755810 +1000 @@ -519,7 +519,6 @@ if(priv) kfree(priv); t->priv = NULL; - t->release=NULL; return 0; } @@ -574,7 +573,7 @@ dev->priv=priv; - return 0; + return dev; } EXPORT_SYMBOL(xc3028_attach);
_______________________________________________ linux-dvb mailing list linux-dvb@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
