On Sun, 2012-11-04 at 20:34 +0000, Matthew Garrett wrote: > On Sun, Nov 04, 2012 at 08:27:58PM +0000, Matt Fleming wrote: > > > +#ifdef CONFIG_X86 > > + ops.query_variable_info = efi.query_variable_info; > > +#endif > > Why limit to x86? Otherwise, looks broadly good - I can try to test > tomorrow.
Because from what I can see, not only does ia64 not fill out the query_variable_info() pointer in struct efi, struct efi is in the data segment, and so, contains an uninitialised pointer. Now, the proper approach would be to either implement query_variable_info() or initialise the pointer to NULL. I don't have any ia64 hardware for the former, but would be happy to carry a patch for the latter if everyone else is happy with that. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
