On Wed, 2013-03-13 at 18:47 +0800, Lingzhu Xiang wrote:
> On 03/13/2013 12:35 AM, Matt Fleming wrote:
> >> I think using what we have is good enough for this. I'll verify
> >> boot time tomorrow.
> >
> > That would be great, thank you.
>
> On a Windows 8 logo desktop with 91 variables, the average time (30 runs
> each) of variable iteration goes from 0.009672 second to 0.010180 second
> (+0.000508 second, or +5%). Negligible.
Thanks for testing that.
[...]
> >> By the way, efivar_update_sysfs_entries from Seiji's sysfs workqueue
> >> patch may also get stuck in loop in the same way.
> >
> > You mean if GetNextVariableName() never terminates? Yeah,
> > efivar_update_sysfs_entries() looks like it needs protecting from that
> > too, good catch.
>
> Yes that's what I meant.
Hmm.. actually, I'm not at all sure how to fix that case, since the
algorithm expects to find duplicates.
Seiji, any thoughts here? For a recap of the discussion see,
http://article.gmane.org/gmane.linux.kernel.efi/835
--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
