On 06/05/2013 08:59 AM, Matt Fleming wrote:
> +              * There still isn't enough room, so return an error
> +              */
> +             if (remaining_size - size < 5120)
> +                     return EFI_OUT_OF_RESOURCES;
> +     }

Please don't open-code the constant 5120 in this case.  We may easily
run into a system which needs, say, 7K, and it is error-prone to just
replace numbers.

        -hpa


--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to