On Fri, 13 Jun, at 07:00:21PM, Daniel Kiper wrote:
> v5 - suggestions/fixes:
>    - do not change indentation
>      (suggested by Matt Fleming).
> 
> Signed-off-by: Daniel Kiper <[email protected]>
> ---
>  arch/x86/kernel/setup.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Looks good, but it's customary to have at least one line after the patch
title. Even something as trivial as,

  "We've got constants, so let's use them instead of hard-coded values."

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-efi" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to