On 7 July 2014 22:29, Matt Fleming <[email protected]> wrote: > On Wed, 02 Jul, at 12:10:02PM, Ard Biesheuvel wrote: >> According to section 7.1 of the UEFI spec, Runtime Services are not fully >> reentrant, and there are particular combinations of calls that need to be >> serialized. >> >> Signed-off-by: Ard Biesheuvel <[email protected]> >> --- >> drivers/firmware/efi/runtime-wrappers.c | 109 >> +++++++++++++++++++++++++++++--- >> 1 file changed, 99 insertions(+), 10 deletions(-) > > Ard, what's going on with this one? I didn't see it resubmitted along > with v3 of "efi/arm64: handle missing virtual mapping for UEFI System > Table". > > Note that we already have a lock to serialize access to the UEFI > variable services in the form of __efivars->lock, see > drivers/firmware/efi/vars.c. It's a spinlock because of the context we > may need to create variables in from efi_pstore_write(). >
As the patch says, the UEFI spec is very clear on which combinations of calls are not reentrant. I don't think the rtc_lock and the efivars->lock quite cover that completely ... -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
