> On August 13, 2014 at 7:56 PM Matt Fleming <[email protected]> wrote: > > > On Thu, 10 Jul, at 02:12:41AM, [email protected] wrote: > > @@ -1376,7 +1376,10 @@ struct boot_params *efi_main(struct efi_config *c, > > > > setup_graphics(boot_params); > > > > - setup_efi_pci(boot_params); > > + status = setup_efi_pci(boot_params); > > + if (status != EFI_SUCCESS) { > > + efi_printk(sys_table, "setup_efi_pci() failed!\n"); > > + } > > Actually, it turns out that a lot of people are seeing this error > message in what would be an otherwise quiet boot, > > https://bugzilla.kernel.org/show_bug.cgi?id=81891 > > Maybe we should distinguish between EFI_PCI_IO_PROTOCOL_GUID not being > found and all other errors, i.e. memory allocation failure. We obviously > do want to know if we failed to allocate memory, but we're less bothered > if we've no PCI devices. > > Something like below? Folks on Cc, could you apply this snippet and see > whether you're still seeing the error message? > > --- > > diff --git a/arch/x86/boot/compressed/eboot.c > b/arch/x86/boot/compressed/eboot.c > index f4bdab1dbf66..37743459d089 100644 > --- a/arch/x86/boot/compressed/eboot.c > +++ b/arch/x86/boot/compressed/eboot.c > @@ -534,8 +534,15 @@ static efi_status_t setup_efi_pci(struct boot_params > *params) > NULL, &size, pci_handle); > } > > - if (status != EFI_SUCCESS) > + if (status != EFI_SUCCESS) { > + /* > + * We must have encountered a non-fatal error condition, > + * such as being unable to locate pci_proto. Return, but > + * don't report an error. > + */ > + status = EFI_SUCCESS; > goto free_handle; > + } > > if (efi_early->is64) > status = setup_efi_pci64(params, pci_handle, size); > > -- > Matt Fleming, Intel Open Source Technology Center
Hi Matt, still getting ""setup_efi_pci() failed!" on my Dell XPS 13 with that patch. But so far no bad efi kernel image boot any more since https://bugzilla.kernel.org/show_bug.cgi?id=68761 has been fixed. Cheers, Ulf -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
