On Tue, 01 Dec, at 11:50:20AM, Ard Biesheuvel wrote: > The UEFI spec allows Runtime Services to be invoked with interrupts > enabled. The only reason we were disabling interrupts was to prevent > recursive calls into the services on the same CPU, which will lead to > deadlock. However, the only context where such invocations may occur > legally is from efi-pstore via efivars, and that code has been updated > to call a non-blocking alternative when invoked from a non-interruptible > context. > > So instead, update the ordinary, blocking UEFI Runtime Services wrappers > to execute with interrupts enabled. This aims to prevent excessive interrupt > latencies on uniprocessor platforms with slow variable stores. > > Signed-off-by: Ard Biesheuvel <[email protected]> > --- > drivers/firmware/efi/runtime-wrappers.c | 73 ++++++++------------ > 1 file changed, 30 insertions(+), 43 deletions(-)
Thanks Ard, this and all the other patches in this series look good to me, apart from the comments I had for patch 4. Once that is resolved I'd like to get this queued up for v4.5. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
