> > > Why make this optional? > > > > I made it as a config option in RFC because the page fault handler was > > complicated and touching many parts (it had lots of code change and I > > didn't want to break any existing functionality). Now that it's > > simple, I don't think we need the config option. > > > > Without efi page fault handler, any page fault caused by firmware > > should panic kernel but with this patch I think we are just improving > > existing > condition (ideally). > > > > So, if Thomas, Ingo, Andy, Ard and Boris are ok.. I will make it as > > default (i.e. without config). > > > > Regards, > > Sai > > > Also, some distributions already have specific ways to handle buggy firmwares > which can be at times dependent on the underlying hardware and the firmware > versions. > > I would suggest that we enable this under a CONFIG for the first round and > once > it is tested with wider variety of x86 machines which have buggy or orphaned > firmware and linux (and reboot) works fine with them, we can drop the CONFIG > option in future and enable this by default.
Sounds fair to me, but, I would like to wait for someone experienced to make the final call. Regards, Sai
