On Fri, Aug 30, 2019 at 11:36:37AM +0800, Gao Xiang wrote:
> As Christoph claimed [1], on-disk format should have
> explicitly assigned numbers. I have to change it.
>
> [1] https://lore.kernel.org/r/20190829095954.gb20...@infradead.org/
> Reported-by: Christoph Hellwig <h...@infradead.org>
> Reviewed-by: Chao Yu <yuch...@huawei.com>
> Signed-off-by: Gao Xiang <gaoxian...@huawei.com>
...ignore this patchset. I will resend another incremental
patchset to address what Christoph suggested yesterday...
Thanks,
Gao Xiang
> ---
> no change
>
> fs/erofs/erofs_fs.h | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/fs/erofs/erofs_fs.h b/fs/erofs/erofs_fs.h
> index afa7d45ca958..2447ad4d0920 100644
> --- a/fs/erofs/erofs_fs.h
> +++ b/fs/erofs/erofs_fs.h
> @@ -52,10 +52,10 @@ struct erofs_super_block {
> * 4~7 - reserved
> */
> enum {
> - EROFS_INODE_FLAT_PLAIN,
> - EROFS_INODE_FLAT_COMPRESSION_LEGACY,
> - EROFS_INODE_FLAT_INLINE,
> - EROFS_INODE_FLAT_COMPRESSION,
> + EROFS_INODE_FLAT_PLAIN = 0,
> + EROFS_INODE_FLAT_COMPRESSION_LEGACY = 1,
> + EROFS_INODE_FLAT_INLINE = 2,
> + EROFS_INODE_FLAT_COMPRESSION = 3,
> EROFS_INODE_LAYOUT_MAX
> };
>
> @@ -181,7 +181,7 @@ struct erofs_xattr_entry {
>
> /* available compression algorithm types */
> enum {
> - Z_EROFS_COMPRESSION_LZ4,
> + Z_EROFS_COMPRESSION_LZ4 = 0,
> Z_EROFS_COMPRESSION_MAX
> };
>
> @@ -239,10 +239,10 @@ struct z_erofs_map_header {
> * (di_advise could be 0, 1 or 2)
> */
> enum {
> - Z_EROFS_VLE_CLUSTER_TYPE_PLAIN,
> - Z_EROFS_VLE_CLUSTER_TYPE_HEAD,
> - Z_EROFS_VLE_CLUSTER_TYPE_NONHEAD,
> - Z_EROFS_VLE_CLUSTER_TYPE_RESERVED,
> + Z_EROFS_VLE_CLUSTER_TYPE_PLAIN = 0,
> + Z_EROFS_VLE_CLUSTER_TYPE_HEAD = 1,
> + Z_EROFS_VLE_CLUSTER_TYPE_NONHEAD = 2,
> + Z_EROFS_VLE_CLUSTER_TYPE_RESERVED = 3,
> Z_EROFS_VLE_CLUSTER_TYPE_MAX
> };
>
> --
> 2.17.1
>
