On Sat, Jul 24, 2021 at 01:41:31AM +0800, Gao Xiang wrote:
> Add support for reading inline data content into the page cache from
> nonzero page-aligned file offsets. This enables the EROFS tailpacking
> mode where the last few bytes of the file are stored right after the
> inode.
>
> The buffered write path remains untouched since EROFS cannot be used
> for testing. It'd be better to be implemented if upcoming real users
> care and provide a real pattern rather than leave untested dead code
> around.
My one complaint with this version is the subject line. It's a bit vague.
I went with:
iomap: Support file tail packing
I also wrote a changelog entry that reads:
The existing inline data support only works for cases where the entire
file is stored as inline data. For larger files, EROFS stores the
initial blocks separately and then can pack a small tail adjacent to
the inode. Generalise inline data to allow for tail packing. Tails
may not cross a page boundary in memory.
... but I'm not sure that's necessarily better than what you've written
here.
> Cc: Christoph Hellwig <[email protected]>
> Cc: Darrick J. Wong <[email protected]>
> Cc: Matthew Wilcox <[email protected]>
> Cc: Andreas Gruenbacher <[email protected]>
> Tested-by: Huang Jianan <[email protected]> # erofs
> Signed-off-by: Gao Xiang <[email protected]>
Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>
