Hi Bo,
On Thu, Aug 19, 2021 at 06:28:04AM +0800, Liu Bo wrote:
> On Wed, Aug 18, 2021 at 03:07:12PM +0800, Gao Xiang wrote:
...
> > + EROFS_INODE_CHUNK_BASED = 4,
> > EROFS_INODE_DATALAYOUT_MAX
> > };
> >
> > @@ -90,6 +96,19 @@ static inline bool
> > erofs_inode_is_data_compressed(unsigned int datamode)
> > #define EROFS_I_ALL \
> > ((1 << (EROFS_I_DATALAYOUT_BIT + EROFS_I_DATALAYOUT_BITS)) - 1)
> >
> > +/* indicate chunk blkbits, thus `chunksize = blocksize << chunk blkbits' */
>
> A typo in the quotation marks. (`chunksize = ) should be ('chunksize =)
Such usage is like below:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0e389028ad75412ff624b304913bba14f8d46ec4
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=78128fabd022240852859c0b253972147593690b
I'm fine in either way. I'll update it in the next version or when
submitting.
>
> Otherwise it looks good.
>
> Reviewed-by: Liu Bo <[email protected]>
Thanks for the review!
Thanks,
Gao Xiang
>
> thanks,
> liubo
>
