Hi Jianan, On Wed, Aug 25, 2021 at 11:34:16AM +0800, Huang Jianan via Linux-erofs wrote:
Subject: AOSP: erofs-utils: increase val for AOSP-specific long options > Signed-off-by: Huang Jianan <[email protected]> > --- > mkfs/main.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/mkfs/main.c b/mkfs/main.c > index 10fe14d..9369b72 100644 > --- a/mkfs/main.c > +++ b/mkfs/main.c > @@ -45,10 +45,10 @@ static struct option long_options[] = { > #endif > {"max-extent-bytes", required_argument, NULL, 9}, > #ifdef WITH_ANDROID > - {"mount-point", required_argument, NULL, 10}, > - {"product-out", required_argument, NULL, 11}, > - {"fs-config-file", required_argument, NULL, 12}, > - {"block-list-file", required_argument, NULL, 13}, > + {"mount-point", required_argument, NULL, 256}, > + {"product-out", required_argument, NULL, 257}, > + {"fs-config-file", required_argument, NULL, 258}, > + {"block-list-file", required_argument, NULL, 259}, > #endif > {0, 0, 0, 0}, > }; > @@ -289,20 +289,20 @@ static int mkfs_parse_options_cfg(int argc, char > *argv[]) > } > break; > #ifdef WITH_ANDROID > - case 10: > + case 256: How about using larger numbers such as 512 for AOSP-specific options? I'm afraid in the future we might bump up generic options to >= 256 like this as well. Otherwise looks good to me. Thanks, Gao Xiang
