On 2023/8/15 12:55, Yue Hu wrote:
From: Yue Hu <[email protected]> We can determine whether the tail block is the first one or not during the writing process. Therefore, instead of internally checking the block number for the tail block map, just simply pass the flag. Also, add the missing sbi argument to macro erofs_blknr.
Could you submit a patch to fix this issue first?
Signed-off-by: Yue Hu <[email protected]> --- v2: change commit message a bit include/erofs/block_list.h | 4 ++-- lib/block_list.c | 5 ++--- lib/inode.c | 9 +++++++-- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/include/erofs/block_list.h b/include/erofs/block_list.h index 78fab44..e0dced8 100644 --- a/include/erofs/block_list.h +++ b/include/erofs/block_list.h @@ -19,7 +19,7 @@ void erofs_droid_blocklist_fclose(void); void erofs_droid_blocklist_write(struct erofs_inode *inode, erofs_blk_t blk_start, erofs_blk_t nblocks); void erofs_droid_blocklist_write_tail_end(struct erofs_inode *inode, - erofs_blk_t blkaddr); + erofs_blk_t blkaddr, bool first_block);
I still have no idea why we need this, could you describe the Android block map details for discussion? Thanks, Gao Xiang
