On 2023/10/31 14:05, Gao Xiang wrote:
As Linus pointed out [1], lockref_put_return() is fundamentally
designed to be something that can fail. It behaves as a fastpath-only
thing, and the failure case needs to be handled anyway.
Actually, since the new pcluster was just allocated without being
populated, it won't be accessed by others until it is inserted into
XArray, so lockref helpers are actually unneeded here.
Let's just set the proper reference count on initializing.
[1]
https://lore.kernel.org/r/CAHk-=whcga8beqnj3zbh_hfm9ctba_wpf444lpwrybvnmzo...@mail.gmail.com
Fixes: 7674a42f35ea ("erofs: use struct lockref to replace handcrafted
approach")
Signed-off-by: Gao Xiang <[email protected]>
Reviewed-by: Chao Yu <[email protected]>
Thanks,
