On 2024/3/15 15:18, Noboru Asai wrote:
I think it is easier to understand the source code if the names of variables and pointers in the same structure are unified. struct z_erofs_compress_ictx inode_ctx; // i stands for inode? struct z_erofs_compress_ictx *ictx; struct z_erofs_compress_sctx seg_ctx; struct z_erofs_compress_sctx *sctx;
"ictx" means "inode context", "sctx" means "segment context". If there is no confusion, "ctx" naming can be used in a function. Also I tend to avoid making a huge diff to make ctx->"sctx or ictx", otherwise "git blame" will be in a mess. Thanks, Gao Xiang
