On Fri, Aug 02, 2024 at 02:17:12PM -0700, Sandeep Dhavale via Linux-erofs wrote: > Hi Gao, > > On Thu, Aug 1, 2024 at 6:55 PM Gao Xiang <[email protected]> wrote: > > > > Ignore the return values as other close()s instead. > > > > Coverity-id: 502331 > > Signed-off-by: Gao Xiang <[email protected]> > > --- > > fsck/main.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/fsck/main.c b/fsck/main.c > > index fb66967..bbef645 100644 > > --- a/fsck/main.c > > +++ b/fsck/main.c > > @@ -702,11 +702,9 @@ again: > > > > /* verify data chunk layout */ > > ret = erofs_verify_inode_data(inode, fd); > > + close(fd); > > if (ret) > > return ret; > I think we can get rid of this if block and should be just > return ret;
Yeah, agreed, let me revise that. > > - > > - if (close(fd)) > > - return -errno; > > return ret; > > } > > > > -- > > 2.43.5 > > > You can just do that while applying, > > Reviewed-by: Sandeep Dhavale <[email protected]> > Thanks for your review! Thanks, Gao Xiang > Thanks, > Sandeep.
